<html>
<head><meta charset="utf-8"><title>weekly meeting 2019-11-07 #54818 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html">weekly meeting 2019-11-07 #54818</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="180133965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180133965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180133965">(Nov 07 2019 at 13:56)</a>:</h4>
<p>Hi <span class="user-group-mention" data-user-group-id="897">@T-compiler/meeting</span> ; the triage meeting will be starting in 1 hour 4 minutes</p>



<a name="180134009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180134009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180134009">(Nov 07 2019 at 13:57)</a>:</h4>
<p>I will be doing <a href="#narrow/stream/131828-t-compiler/topic/pre-meeting.20triage.202019-11-07.20.2354818/near/180133986" title="#narrow/stream/131828-t-compiler/topic/pre-meeting.20triage.202019-11-07.20.2354818/near/180133986">pre-triage in a parallel topic</a></p>



<a name="180134063"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180134063" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180134063">(Nov 07 2019 at 13:58)</a>:</h4>
<p>This week we have scheduled checkins from WG-polonius and ... WG-rfc-2229</p>



<a name="180134136"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180134136" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180134136">(Nov 07 2019 at 13:58)</a>:</h4>
<p>(but the latter is paused for now, so it will just be WG-polonius)</p>



<a name="180140022"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140022" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140022">(Nov 07 2019 at 15:01)</a>:</h4>
<p>Hi <span class="user-group-mention" data-user-group-id="897">@T-compiler/meeting</span>! Add a <span aria-label="wave" class="emoji emoji-1f44b" role="img" title="wave">:wave:</span> emoji to show you're here :)</p>



<a name="180140160"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140160" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140160">(Nov 07 2019 at 15:02)</a>:</h4>
<p>so lets have five minutes for announcements</p>



<a name="180140175"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140175" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140175">(Nov 07 2019 at 15:02)</a>:</h4>
<p>Here's one: I'm moving to the USA 🇫🇷  →🇺🇸</p>



<a name="180140235"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140235" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140235">(Nov 07 2019 at 15:03)</a>:</h4>
<p>Hopefully it won't disrupt my ability to run the meetings etc too much.</p>



<a name="180140343"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140343" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140343">(Nov 07 2019 at 15:04)</a>:</h4>
<blockquote>
<p>Here's one: I'm moving to the USA</p>
</blockquote>
<p>When are you moving and into what time zone?</p>



<a name="180140423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140423">(Nov 07 2019 at 15:05)</a>:</h4>
<p>/me kind of excited about this</p>



<a name="180140435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140435">(Nov 07 2019 at 15:05)</a>:</h4>
<p>mid-december. Niko's timezone.</p>



<a name="180140470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140470">(Nov 07 2019 at 15:05)</a>:</h4>
<p>gonna have to remove "ex-pat" from my twitter profile and what not.</p>



<a name="180140491"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140491" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140491">(Nov 07 2019 at 15:05)</a>:</h4>
<p>oof, that one hurts</p>



<a name="180140549"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140549" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140549">(Nov 07 2019 at 15:06)</a>:</h4>
<p>good luck!</p>



<a name="180140560"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140560" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140560">(Nov 07 2019 at 15:06)</a>:</h4>
<p>I've been working on the constant propagation pass the last few months and it's finally in a place where it can be enabled by default. A recent <a href="https://perf.rust-lang.org/compare.html?start=0d5264a03c2d873d9e23a22def748b9c6937c537&amp;end=98da694a4fda38435d86b0eb6f09d4f644ef83d4" target="_blank" title="https://perf.rust-lang.org/compare.html?start=0d5264a03c2d873d9e23a22def748b9c6937c537&amp;end=98da694a4fda38435d86b0eb6f09d4f644ef83d4">perf run</a> shows good across the board results so please weigh-in on the poll to decide if we should enable it by default. <a href="https://github.com/rust-lang/rust/pull/66074#issuecomment-550274874" target="_blank" title="https://github.com/rust-lang/rust/pull/66074#issuecomment-550274874">https://github.com/rust-lang/rust/pull/66074#issuecomment-550274874</a></p>



<a name="180140581"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140581" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140581">(Nov 07 2019 at 15:06)</a>:</h4>
<p>That's awesome!</p>



<a name="180140585"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140585" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140585">(Nov 07 2019 at 15:06)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> once it lands, would make a good blog post <em>hint hint</em></p>



<a name="180140590"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140590" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140590">(Nov 07 2019 at 15:06)</a>:</h4>
<p>those numbers are <em>insane</em> btw</p>



<a name="180140634"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140634" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140634">(Nov 07 2019 at 15:07)</a>:</h4>
<p>especially on crates that aren't outright stress tests filled with constants</p>



<a name="180140641"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140641" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140641">(Nov 07 2019 at 15:07)</a>:</h4>
<p>yes, really impressive!</p>



<a name="180140679"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140679" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140679">(Nov 07 2019 at 15:07)</a>:</h4>
<p>There's a bit more work that can be done but it would be nice to start reaping the benefits</p>



<a name="180140735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140735">(Nov 07 2019 at 15:08)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> regarding the poll: is the alternative to just turn it on in release mode alone?</p>



<a name="180140748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140748">(Nov 07 2019 at 15:08)</a>:</h4>
<p>Oh wow, would you look at those perf numbers <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="180140792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140792">(Nov 07 2019 at 15:08)</a>:</h4>
<p>I don't think there's a current alternative proposed. The status quo is that it only runs when <code>-Z mir-opt-level=2</code> which is basically never.</p>



<a name="180140794"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140794" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140794">(Nov 07 2019 at 15:08)</a>:</h4>
<p>Announcement: 1.39.0 release, including async/await is out<br>
- <a href="https://blog.rust-lang.org/2019/11/07/Rust-1.39.0.html" target="_blank" title="https://blog.rust-lang.org/2019/11/07/Rust-1.39.0.html">https://blog.rust-lang.org/2019/11/07/Rust-1.39.0.html</a><br>
- <a href="https://blog.rust-lang.org/2019/11/07/Async-await-stable.html" target="_blank" title="https://blog.rust-lang.org/2019/11/07/Async-await-stable.html">https://blog.rust-lang.org/2019/11/07/Async-await-stable.html</a></p>



<a name="180140821"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140821" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140821">(Nov 07 2019 at 15:09)</a>:</h4>
<p>(Does debug mode see the same benefit in compilation time? If so, why -- I would have assumed the relevant LLVM optimizations are not run)</p>



<a name="180140835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140835">(Nov 07 2019 at 15:09)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span> oh yeah it's thursday already</p>



<a name="180140852"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140852" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140852">(Nov 07 2019 at 15:09)</a>:</h4>
<p>But running in release only is certainly a possible alternative if there are concerns about also running in debug.</p>



<a name="180140864"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140864" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140864">(Nov 07 2019 at 15:09)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> in debug mode a lot of time is spent just generating code and stuff</p>



<a name="180140890"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140890" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140890">(Nov 07 2019 at 15:09)</a>:</h4>
<p>I remember pcwalton stressing about us ending up on the "happy path" of instruction selection</p>



<a name="180140892"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140892" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140892">(Nov 07 2019 at 15:09)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> Yes, for example:</p>
<blockquote>
<p>keccak-debug avg: -12.6%</p>
</blockquote>



<a name="180140941"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140941" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140941">(Nov 07 2019 at 15:10)</a>:</h4>
<p>ah okay, and this avoids that codegen entirely. Makes sense.</p>



<a name="180140965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140965">(Nov 07 2019 at 15:10)</a>:</h4>
<p>I had been assuming the performance gains were from avoiding LLVM trying to recreate the same work on its own</p>



<a name="180140983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140983">(Nov 07 2019 at 15:10)</a>:</h4>
<p>but this makes total sense. Great.</p>



<a name="180140988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180140988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180140988">(Nov 07 2019 at 15:10)</a>:</h4>
<p>Now I just need a reason to use async/await somewhere <code>:P</code></p>



<a name="180141005"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141005" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141005">(Nov 07 2019 at 15:10)</a>:</h4>
<p><span class="user-mention" data-user-id="124287">@mw</span> there's also "References to by-move bindings in match guards"</p>



<a name="180141042"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141042" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141042">(Nov 07 2019 at 15:11)</a>:</h4>
<p>which is the kind of thing that floats my balloon</p>



<a name="180141098"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141098" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141098">(Nov 07 2019 at 15:11)</a>:</h4>
<p>well, landing a feature along with async/await is a good way to have everyone ignore it</p>



<a name="180141166"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141166" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141166">(Nov 07 2019 at 15:12)</a>:</h4>
<p>this is the sort of feature that I think people only "discover" because they suddenly realize they aren't seeing certain compiler errors any more</p>



<a name="180141196"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141196" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141196">(Nov 07 2019 at 15:12)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> if they even realize it at all ^^ (I know I might not have)</p>



<a name="180141201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141201">(Nov 07 2019 at 15:12)</a>:</h4>
<p>which is one of my favorite kinds of features: nothing to learn, just works as you expect</p>



<a name="180141219"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141219" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141219">(Nov 07 2019 at 15:12)</a>:</h4>
<p>Anyway, okay this is all great stuff</p>



<a name="180141273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141273">(Nov 07 2019 at 15:13)</a>:</h4>
<p>My bad news: Not only did I fail to follow through with a P-high traversal last week, but I also didn't get to it this week either</p>



<a name="180141294"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141294" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141294">(Nov 07 2019 at 15:13)</a>:</h4>
<p>the good news is: the number of P-high bugs has nonehteless gone down. :)</p>



<a name="180141298"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141298" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141298">(Nov 07 2019 at 15:13)</a>:</h4>
<p>There's also <code>#[cfg(windows)] slice: &amp;[u16]</code> <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="180141325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141325">(Nov 07 2019 at 15:13)</a>:</h4>
<p>(<a href="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen+is%3Aissue+label%3AT-compiler+label%3AP-high+" target="_blank" title="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen+is%3Aissue+label%3AT-compiler+label%3AP-high+">29 open</a> P-high issues now, 15 of them <a href="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen+is%3Aissue+label%3AT-compiler+label%3AP-high+no%3Aassignee" target="_blank" title="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen+is%3Aissue+label%3AT-compiler+label%3AP-high+no%3Aassignee">unassigned</a>.)</p>



<a name="180141328"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141328" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141328">(Nov 07 2019 at 15:13)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span> fn param or field?</p>



<a name="180141376"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141376" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141376">(Nov 07 2019 at 15:14)</a>:</h4>
<p><span class="user-mention" data-user-id="119009">@eddyb</span> param</p>



<a name="180141472"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141472" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141472">(Nov 07 2019 at 15:14)</a>:</h4>
<p>so lets see. We have a beta-nomination:</p>



<a name="180141516"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141516" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141516">(Nov 07 2019 at 15:15)</a>:</h4>
<p>beta backport nom: "Do not ICE with a precision flag in formatting str and no format arguments" <a href="https://github.com/rust-lang/rust/issues/66093" target="_blank" title="https://github.com/rust-lang/rust/issues/66093">#66093</a></p>



<a name="180141670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141670">(Nov 07 2019 at 15:16)</a>:</h4>
<p>seems fine for beta backport</p>



<a name="180141682"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141682" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141682">(Nov 07 2019 at 15:16)</a>:</h4>
<p>so beta-accepted</p>



<a name="180141695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141695">(Nov 07 2019 at 15:16)</a>:</h4>
<p>the same PR is also up for:</p>



<a name="180141709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141709">(Nov 07 2019 at 15:16)</a>:</h4>
<p>stable backport nom:  "Do not ICE with a precision flag in formatting str and no format arguments" <a href="https://github.com/rust-lang/rust/issues/66093" target="_blank" title="https://github.com/rust-lang/rust/issues/66093">#66093</a></p>



<a name="180141781"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141781" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141781">(Nov 07 2019 at 15:17)</a>:</h4>
<p>(my personal inclination is that this doesn't really meet the bar for a stable backport. but I guess my attitude is mostly a shrug.)</p>



<a name="180141852"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141852" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141852">(Nov 07 2019 at 15:18)</a>:</h4>
<p>unless this is a stable-to-stable regression ... ?</p>



<a name="180141854"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141854" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141854">(Nov 07 2019 at 15:18)</a>:</h4>
<p>(Release team will separately decide if the sum total of the stable backports merit a point release)</p>



<a name="180141865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141865">(Nov 07 2019 at 15:18)</a>:</h4>
<p>I guess it is a stable-to-stable regression. But even then</p>



<a name="180141872"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141872" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141872">(Nov 07 2019 at 15:18)</a>:</h4>
<blockquote>
<p>(my personal inclination is that this doesn't really meet the bar for a stable backport. but I guess my attitude is mostly a shrug.)</p>
</blockquote>
<p>I think we're just judging the technical merits</p>



<a name="180141878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141878">(Nov 07 2019 at 15:18)</a>:</h4>
<p>this seems "safe" to backport</p>



<a name="180141893"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141893" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141893">(Nov 07 2019 at 15:18)</a>:</h4>
<p>yes that is fair</p>



<a name="180141903"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141903" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141903">(Nov 07 2019 at 15:19)</a>:</h4>
<p>The reason I put stable to stable ices like this one up for stable backport is because they can bring the rls down.</p>



<a name="180141949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141949">(Nov 07 2019 at 15:19)</a>:</h4>
<p>every time I hear that, the back of my mind thinks "that sounds like an architectural problem with the rls"</p>



<a name="180141961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141961">(Nov 07 2019 at 15:19)</a>:</h4>
<p>With full understanding that they are unlikely to actually end up in the current stable release</p>



<a name="180141965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141965">(Nov 07 2019 at 15:19)</a>:</h4>
<p>but maybe by "down" you just mean "fails to produce useful results until the problem in source code is addressed."</p>



<a name="180141968"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180141968" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180141968">(Nov 07 2019 at 15:20)</a>:</h4>
<p><span class="user-mention" data-user-id="119031">@Esteban Küber</span> worth noting that on the PR for the benefit of the release team ^^</p>



<a name="180142016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142016">(Nov 07 2019 at 15:20)</a>:</h4>
<p>it will restart itself like 5 times then give up AFAIK</p>



<a name="180142067"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142067" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142067">(Nov 07 2019 at 15:20)</a>:</h4>
<p><span class="user-mention" data-user-id="119009">@eddyb</span> even in the face of further changes to the input source code?</p>



<a name="180142071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142071">(Nov 07 2019 at 15:20)</a>:</h4>
<p>This one is insidious because it is very easy to hit when writing code.</p>



<a name="180142121"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142121" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142121">(Nov 07 2019 at 15:21)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> I'm not sure exactly what the failure mode looks like but there's always Ctrl+Shift+P "restart RLS" once you've fixed the input</p>



<a name="180142123"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142123" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142123">(Nov 07 2019 at 15:21)</a>:</h4>
<p>okay well this probably is not the right moment to get into details of RLS architecture.</p>



<a name="180142152"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142152" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142152">(Nov 07 2019 at 15:21)</a>:</h4>
<p>there used to be a lot of these issues due to librustc_save_analysis bugs</p>



<a name="180142199"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142199" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142199">(Nov 07 2019 at 15:22)</a>:</h4>
<p>Aside: I cannot recommend rust-analyzer + VSCode enough for hacking on rustc; it works super smoothly, even when using a networked filesystem</p>



<a name="180142247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142247">(Nov 07 2019 at 15:22)</a>:</h4>
<p>/me is too stubborn to switch to the winning team</p>



<a name="180142293"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142293" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142293">(Nov 07 2019 at 15:23)</a>:</h4>
<p>/me doesn't like that framing :)</p>



<a name="180142307"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142307" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142307">(Nov 07 2019 at 15:23)</a>:</h4>
<p>(though I'm sure you're joking ;)</p>



<a name="180142327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142327">(Nov 07 2019 at 15:24)</a>:</h4>
<p>okay, lets quickly skim over the open <a href="https://github.com/rust-lang/rust/labels/regression-from-stable-to-beta" target="_blank" title="https://github.com/rust-lang/rust/labels/regression-from-stable-to-beta">stable-to-beta regressions</a></p>



<a name="180142428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142428">(Nov 07 2019 at 15:24)</a>:</h4>
<p>(some of which I assume need to now be reclassified as stable-to-stable regressions)</p>



<a name="180142477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142477">(Nov 07 2019 at 15:25)</a>:</h4>
<p>1/4: "non-empty glob statement regression 1.39" <a href="https://github.com/rust-lang/rust/issues/65523" target="_blank" title="https://github.com/rust-lang/rust/issues/65523">#65523</a></p>



<a name="180142498"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142498" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142498">(Nov 07 2019 at 15:25)</a>:</h4>
<p>was this resolved by <a href="https://github.com/rust-lang/rust/issues/65539" target="_blank" title="https://github.com/rust-lang/rust/issues/65539">#65539</a> ?</p>



<a name="180142512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142512">(Nov 07 2019 at 15:25)</a>:</h4>
<p>believe so, can be closed</p>



<a name="180142603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142603">(Nov 07 2019 at 15:26)</a>:</h4>
<p>2/4: "bindgen changes in 1.39" <a href="https://github.com/rust-lang/rust/issues/65520" target="_blank" title="https://github.com/rust-lang/rust/issues/65520">#65520</a></p>



<a name="180142662"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142662" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142662">(Nov 07 2019 at 15:26)</a>:</h4>
<p>the "remaining  work" here was to look at the affected crates to try to confirm if this is just expected fallout</p>



<a name="180142683"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142683" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142683">(Nov 07 2019 at 15:27)</a>:</h4>
<p>I spent my time on other bugs though</p>



<a name="180142702"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142702" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142702">(Nov 07 2019 at 15:27)</a>:</h4>
<p>So looking for volunteers iow</p>



<a name="180142706"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142706" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142706">(Nov 07 2019 at 15:27)</a>:</h4>
<p>I did do some of that</p>



<a name="180142719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142719">(Nov 07 2019 at 15:27)</a>:</h4>
<p>er, wait, maybe not on that issue</p>



<a name="180142738"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142738" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142738">(Nov 07 2019 at 15:27)</a>:</h4>
<p>yeah I think a bunch of these end up being bindgen but they were put into separate buckets</p>



<a name="180142753"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142753" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142753">(Nov 07 2019 at 15:27)</a>:</h4>
<p>but the ones I tested all proved to be bindgen</p>



<a name="180142754"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142754" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142754">(Nov 07 2019 at 15:27)</a>:</h4>
<p>so my question is: Do we bother keeping this open?</p>



<a name="180142756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142756">(Nov 07 2019 at 15:27)</a>:</h4>
<p>I thnk we can assume it is</p>



<a name="180142831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142831">(Nov 07 2019 at 15:28)</a>:</h4>
<p>I don't think its worth spending more time on at this point. The investigation is worthwhile if it can catch a bug before release itself</p>



<a name="180142837"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142837" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142837">(Nov 07 2019 at 15:28)</a>:</h4>
<p>hmm</p>



<a name="180142841"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142841" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142841">(Nov 07 2019 at 15:28)</a>:</h4>
<p>I'm skimming the logs</p>



<a name="180142870"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142870" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142870">(Nov 07 2019 at 15:28)</a>:</h4>
<p>but now that release is out, I think we might as well just let people file more specific tickets?</p>



<a name="180142875"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142875" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142875">(Nov 07 2019 at 15:28)</a>:</h4>
<p>I can try to do some testing during meeting but anyway I think I agree</p>



<a name="180142882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180142882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180142882">(Nov 07 2019 at 15:28)</a>:</h4>
<p>the logs are a bit more varied than I expected</p>



<a name="180143053"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143053" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143053">(Nov 07 2019 at 15:30)</a>:</h4>
<p>I <em>think</em> the three scenarios that arise in the logs there (failure to impl <code>Copy</code>, failure to impl <code>PartialEq</code>, and failure to impl <code>fmt::Debug</code>) all can arise as fallout from the bindgen thing</p>



<a name="180143077"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143077" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143077">(Nov 07 2019 at 15:30)</a>:</h4>
<p>but that is based on a very rough memory from when I last looked into the issues here</p>



<a name="180143252"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143252" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143252">(Nov 07 2019 at 15:32)</a>:</h4>
<p>3/4: 'ICE: "Tried to access field 0 of union with 0 fields"' <a href="https://github.com/rust-lang/rust/issues/65462" target="_blank" title="https://github.com/rust-lang/rust/issues/65462">#65462</a></p>



<a name="180143275"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143275" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143275">(Nov 07 2019 at 15:32)</a>:</h4>
<p>I dropped the ball here :/</p>



<a name="180143284"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143284" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143284">(Nov 07 2019 at 15:32)</a>:</h4>
<p>nah its a collective fail, <span class="user-mention" data-user-id="119009">@eddyb</span></p>



<a name="180143310"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143310" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143310">(Nov 07 2019 at 15:33)</a>:</h4>
<p>anyway we'll get to it.</p>



<a name="180143341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143341">(Nov 07 2019 at 15:33)</a>:</h4>
<p>Should I reassign this bug to you <span class="user-mention" data-user-id="119009">@eddyb</span> , or should I go ahead and try to puzzle it out myself?</p>



<a name="180143357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143357">(Nov 07 2019 at 15:33)</a>:</h4>
<p>well, to be fair, someone else failed to track it down to <span class="user-mention" data-user-id="124288">@oli</span>'s change, neither of us saw the issue until weeks later and then <span class="user-mention" data-user-id="124288">@oli</span> went on vacation while I forgot about it further :P</p>



<a name="180143394"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143394" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143394">(Nov 07 2019 at 15:33)</a>:</h4>
<p>I'll let <span class="user-mention" data-user-id="119009">@eddyb</span> decide on their own whether they want to reassign it to themselves</p>



<a name="180143400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143400">(Nov 07 2019 at 15:33)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> elsewhere <span class="user-mention" data-user-id="124288">@oli</span> said that they want to backport removing the assertion and then try to fix the actual problem on nightly</p>



<a name="180143415"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143415" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143415">(Nov 07 2019 at 15:34)</a>:</h4>
<p>i see. okay.</p>



<a name="180143474"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143474" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143474">(Nov 07 2019 at 15:34)</a>:</h4>
<p>but they can't be here today because travel</p>



<a name="180143476"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143476" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143476">(Nov 07 2019 at 15:34)</a>:</h4>
<p>is this on beta now?</p>



<a name="180143485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143485">(Nov 07 2019 at 15:34)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> yeah</p>



<a name="180143486"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143486" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143486">(Nov 07 2019 at 15:34)</a>:</h4>
<p>yep</p>



<a name="180143490"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143490" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143490">(Nov 07 2019 at 15:34)</a>:</h4>
<p>removing the asseron seems like an easy PR to make</p>



<a name="180143513"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143513" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143513">(Nov 07 2019 at 15:34)</a>:</h4>
<p>yep</p>



<a name="180143529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143529">(Nov 07 2019 at 15:34)</a>:</h4>
<p>shouldn't the assertion and the actual problem be addressed in the same PR?</p>



<a name="180143547"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143547" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143547">(Nov 07 2019 at 15:35)</a>:</h4>
<p>not necessarily</p>



<a name="180143620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143620">(Nov 07 2019 at 15:35)</a>:</h4>
<p>or... to rephrase... what is the "actual problem"? :P</p>



<a name="180143698"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143698" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143698">(Nov 07 2019 at 15:36)</a>:</h4>
<p>Yeah I don't know, I'm not sure how hard the actual fix is either, I imagine <span class="user-mention" data-user-id="119009">@eddyb</span> is best positioned to answer</p>



<a name="180143704"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143704" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143704">(Nov 07 2019 at 15:36)</a>:</h4>
<p>since they seemed familiar with the bug</p>



<a name="180143729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143729">(Nov 07 2019 at 15:36)</a>:</h4>
<p>I'd definitely prefer we don't just remove the assertion and leave it at that (assuming the assertion is correct of course)</p>



<a name="180143742"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143742" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143742">(Nov 07 2019 at 15:36)</a>:</h4>
<p>I have no idea what it's from, <span class="user-mention" data-user-id="124288">@oli</span> fixed one thing that was affecting miri</p>



<a name="180143789"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143789" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143789">(Nov 07 2019 at 15:37)</a>:</h4>
<p>I wonder if it's realted to the changes we made around ZSTs</p>



<a name="180143791"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143791" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143791">(Nov 07 2019 at 15:37)</a>:</h4>
<p>note that the regression is from a somewhat useless assertion being copied from miri to the general version of the code</p>



<a name="180143804"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143804" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143804">(Nov 07 2019 at 15:37)</a>:</h4>
<p>at this point I think the only question is whether someone else wants to take the lead on the follow-on work or not.</p>



<a name="180143805"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143805" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143805">(Nov 07 2019 at 15:37)</a>:</h4>
<p>seems like we should assign someone to dig in.?</p>



<a name="180143809"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143809" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143809">(Nov 07 2019 at 15:37)</a>:</h4>
<p>If so, please work-steal from me</p>



<a name="180143817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143817">(Nov 07 2019 at 15:37)</a>:</h4>
<p>the underlying issue is likely years old</p>



<a name="180143828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143828">(Nov 07 2019 at 15:37)</a>:</h4>
<p>just assign <span class="user-mention" data-user-id="124288">@oli</span> they said they want to look into this</p>



<a name="180143830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143830">(Nov 07 2019 at 15:38)</a>:</h4>
<p>Oliver is back, so assign to them? <span aria-label="point up" class="emoji emoji-1f446" role="img" title="point up">:point_up:</span></p>



<a name="180143900"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143900" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143900">(Nov 07 2019 at 15:38)</a>:</h4>
<p>Okay. Its P-high so presumably I'll see it again next week if <span class="user-mention" data-user-id="124288">@oli</span> doesn't get around to it.</p>



<a name="180143996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180143996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180143996">(Nov 07 2019 at 15:39)</a>:</h4>
<p>stable-to-beta regression 4/4: "Undefined symbol _fltused when compiling to x86_64-unknown-uefi" <a href="https://github.com/rust-lang/rust/issues/62785" target="_blank" title="https://github.com/rust-lang/rust/issues/62785">#62785</a></p>



<a name="180144022"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144022" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144022">(Nov 07 2019 at 15:39)</a>:</h4>
<p>oh man I keep looking at this every week</p>



<a name="180144082"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144082" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144082">(Nov 07 2019 at 15:40)</a>:</h4>
<p>and every week I follow the chain</p>



<a name="180144102"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144102" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144102">(Nov 07 2019 at 15:40)</a>:</h4>
<p>until I get to PR <a href="https://github.com/rust-lang/compiler-builtins/issues/317" target="_blank" title="https://github.com/rust-lang/compiler-builtins/issues/317">rust-lang/compiler-builtins#317</a></p>



<a name="180144121"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144121" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144121">(Nov 07 2019 at 15:40)</a>:</h4>
<p>we need a :deja vu: emoji</p>



<a name="180144130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144130">(Nov 07 2019 at 15:41)</a>:</h4>
<p><span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<a name="180144139"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144139" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144139">(Nov 07 2019 at 15:41)</a>:</h4>
<p>I think its time for me to post a note there</p>



<a name="180144276"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144276" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144276">(Nov 07 2019 at 15:42)</a>:</h4>
<blockquote>
<p>we need a :deja vu: emoji</p>
</blockquote>
<p>That <span aria-label="cat" class="emoji emoji-1f408" role="img" title="cat">:cat:</span> is obviously the cat in the stairwell from Matrix</p>



<a name="180144278"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144278" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144278">(Nov 07 2019 at 15:42)</a>:</h4>
<p>okay that's all the stable-to-beta regressions</p>



<a name="180144305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144305">(Nov 07 2019 at 15:42)</a>:</h4>
<p>the only stable-to-nightly regression we haven't already discussed is also a nominated issue</p>



<a name="180144314"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144314" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144314">(Nov 07 2019 at 15:42)</a>:</h4>
<p>so lets just jump to the nominated issues/PR's</p>



<a name="180144333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144333">(Nov 07 2019 at 15:42)</a>:</h4>
<p>nominations: <a href="https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AI-nominated+label%3AT-compiler" target="_blank" title="https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AI-nominated+label%3AT-compiler">https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AI-nominated+label%3AT-compiler</a></p>



<a name="180144337"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144337" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144337">(Nov 07 2019 at 15:43)</a>:</h4>
<p>there are four</p>



<a name="180144355"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144355" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144355">(Nov 07 2019 at 15:43)</a>:</h4>
<p>nom 1/4: "ICE in const fn evaluation - Disagreement between legacy and dataflow-based const validators when a const fn takes &amp;mut self" <a href="https://github.com/rust-lang/rust/issues/66167" target="_blank" title="https://github.com/rust-lang/rust/issues/66167">#66167</a></p>



<a name="180144386"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144386" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144386">(Nov 07 2019 at 15:43)</a>:</h4>
<p>here we have an ICE because there's some sort of consistency check between new and old const-checking</p>



<a name="180144407"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144407" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144407">(Nov 07 2019 at 15:43)</a>:</h4>
<p>that is failing for this input</p>



<a name="180144482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144482">(Nov 07 2019 at 15:44)</a>:</h4>
<p>looks like it's "ICE on top of error", not just ICE for non-erroring code?</p>



<a name="180144487"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144487" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144487">(Nov 07 2019 at 15:44)</a>:</h4>
<p>right</p>



<a name="180144491"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144491" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144491">(Nov 07 2019 at 15:44)</a>:</h4>
<p>so there are a couple things here</p>



<a name="180144510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144510">(Nov 07 2019 at 15:44)</a>:</h4>
<ol>
<li><span class="user-mention" data-user-id="118594">@ecstatic-morse</span> has already weighed in saying they are not inclined to bother fixing this</li>
</ol>



<a name="180144525"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144525" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144525">(Nov 07 2019 at 15:44)</a>:</h4>
<p>based on argument that the problem will go away once the old const-check goes away</p>



<a name="180144546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144546">(Nov 07 2019 at 15:45)</a>:</h4>
<p>the timeframe is likely a week or two btw, judging from my discussions with them</p>



<a name="180144561"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144561" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144561">(Nov 07 2019 at 15:45)</a>:</h4>
<p>so my question in response to that: Do we have an ETA for the old const-check to go away?</p>



<a name="180144580"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144580" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144580">(Nov 07 2019 at 15:45)</a>:</h4>
<p>ah okay</p>



<a name="180144591"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144591" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144591">(Nov 07 2019 at 15:45)</a>:</h4>
<p>if its really just a week or two, then this is fine</p>



<a name="180144619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144619">(Nov 07 2019 at 15:46)</a>:</h4>
<p>I'm coming at this from the NLL effort where we had a much different timeline.</p>



<a name="180144665"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144665" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144665">(Nov 07 2019 at 15:46)</a>:</h4>
<p>I think we're already landing removing parts of the old code for this</p>



<a name="180144710"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144710" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144710">(Nov 07 2019 at 15:46)</a>:</h4>
<p>yeah this is an order or two of magnitude less implementation logic to worry about</p>



<a name="180144729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144729">(Nov 07 2019 at 15:46)</a>:</h4>
<p>okay that's fine then.</p>



<a name="180144732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144732">(Nov 07 2019 at 15:46)</a>:</h4>
<p>lets move along</p>



<a name="180144764"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144764" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144764">(Nov 07 2019 at 15:47)</a>:</h4>
<p>nom 2/4: "[WIP] Make a table of trait object type_ids and vtable pointers available to programs" <a href="https://github.com/rust-lang/rust/issues/66113" target="_blank" title="https://github.com/rust-lang/rust/issues/66113">#66113</a></p>



<a name="180144816"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144816" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144816">(Nov 07 2019 at 15:47)</a>:</h4>
<p>there was some <a href="#narrow/stream/131828-t-compiler/topic/pre-meeting.20triage.202019-11-07.20.2354818/near/180139806" title="#narrow/stream/131828-t-compiler/topic/pre-meeting.20triage.202019-11-07.20.2354818/near/180139806">discussion</a> of this at end of pre-triage</p>



<a name="180144897"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144897" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144897">(Nov 07 2019 at 15:48)</a>:</h4>
<p>I've done this sort of thing by hand with macros for opt-in, my personal opinion is that rustc shouldn't do this for you, but I'd prefer leaving that debate to an RFC</p>



<a name="180144901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144901">(Nov 07 2019 at 15:48)</a>:</h4>
<p>imo this is too fresh to discuss now (same for lang team meeting also really)</p>



<a name="180144902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144902">(Nov 07 2019 at 15:48)</a>:</h4>
<p>I think most people present in that conversation were inclined to say that a change like this should probably go through the RFC process. (And I separately wondered about a design meeting)</p>



<a name="180144908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144908">(Nov 07 2019 at 15:48)</a>:</h4>
<p>Hmm. My first reaction is that I would want this to go forward only in the context of a larger effort. It's the usual tension, though, that this effort is likely not on our priority list just now.</p>



<a name="180144957"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180144957" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180144957">(Nov 07 2019 at 15:49)</a>:</h4>
<p>So I just wanted to see if anyone <em>in this meeting</em> wanted to argue against pushing for RFC here</p>



<a name="180145009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145009">(Nov 07 2019 at 15:49)</a>:</h4>
<p>I wouldn't; but imo in a week we would all be better read in to provide a more thorough answer</p>



<a name="180145073"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145073" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145073">(Nov 07 2019 at 15:50)</a>:</h4>
<p>(feel free to interrupt later in meeting if you want to make such an argument. but for now I'll move along.)</p>



<a name="180145116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145116">(Nov 07 2019 at 15:50)</a>:</h4>
<blockquote>
<p>I wouldn't; but imo in a week we would all be better read in to provide a more thorough answer</p>
</blockquote>
<p>I'm not sure I understand: Are you saying we/I should wait a week in any case before posting a response on that PR ?</p>



<a name="180145144"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145144" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145144">(Nov 07 2019 at 15:50)</a>:</h4>
<p>basically yes; I'm sorta arguing for "procrastination" ^^</p>



<a name="180145169"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145169" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145169">(Nov 07 2019 at 15:51)</a>:</h4>
<p>they could spend that week writing an RFC tbh</p>



<a name="180145173"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145173" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145173">(Nov 07 2019 at 15:51)</a>:</h4>
<p>because ... some of us will read the PR and change our minds about whether it needs an RFC?</p>



<a name="180145210"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145210" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145210">(Nov 07 2019 at 15:51)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> I don't think that would be the outcome, but it would be "needs an RFC + context" instead of just "needs an RFC"</p>



<a name="180145215"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145215" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145215">(Nov 07 2019 at 15:51)</a>:</h4>
<p>even if the implementation is non-invasive, the <em>feature</em> likely warrants some wider discussion</p>



<a name="180145219"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145219" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145219">(Nov 07 2019 at 15:51)</a>:</h4>
<p>(or maybe its just a matter of needing time to read the description on that PR. Because it is a beast,I'll admit)</p>



<a name="180145298"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145298" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145298">(Nov 07 2019 at 15:52)</a>:</h4>
<p>I see, this is more about fine-tuning the feedback so that the PR author gets the right impression</p>



<a name="180145318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145318">(Nov 07 2019 at 15:52)</a>:</h4>
<p>yeah something like that, I think</p>



<a name="180145363"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145363" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145363">(Nov 07 2019 at 15:53)</a>:</h4>
<p>Okay well I guess I'll leave it nominated and we can talk about it again next week. Though I do think <span class="user-mention" data-user-id="119009">@eddyb</span> has a point that early feedback may be better in terms of how people choose to invest their time...</p>



<a name="180145384"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145384" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145384">(Nov 07 2019 at 15:53)</a>:</h4>
<p>okay next up</p>



<a name="180145391"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145391" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145391">(Nov 07 2019 at 15:53)</a>:</h4>
<p>nom 3/4: "Some features can no longer be controlled by conditional compilation" <a href="https://github.com/rust-lang/rust/issues/65860" target="_blank" title="https://github.com/rust-lang/rust/issues/65860">#65860</a></p>



<a name="180145432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145432">(Nov 07 2019 at 15:53)</a>:</h4>
<p>I think you all remember our discussion about this from last week</p>



<a name="180145511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145511">(Nov 07 2019 at 15:54)</a>:</h4>
<p>the reason its still nominated (even though follow-up PR's landed to remove the regressive behavior from beta) ...</p>



<a name="180145543"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145543" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145543">(Nov 07 2019 at 15:54)</a>:</h4>
<p>... is because there is still a general sense from some stake-holders that we need a conversation about the approach here</p>



<a name="180145675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145675">(Nov 07 2019 at 15:56)</a>:</h4>
<p>the question in my mind is whether (1) its the sort of discussion we can hope to have either (1a) asynchronously or (1b) very quickly in THursday meeting ...</p>



<a name="180145687"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145687" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145687">(Nov 07 2019 at 15:56)</a>:</h4>
<p>or if (2) it needs  a design meeting slot on Friday</p>



<a name="180145716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145716">(Nov 07 2019 at 15:56)</a>:</h4>
<p>I don't have an answer to that question. So I'm raising it here.</p>



<a name="180145751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145751">(Nov 07 2019 at 15:56)</a>:</h4>
<p>I don't think we can discuss it in this meeting</p>



<a name="180145781"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145781" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145781">(Nov 07 2019 at 15:57)</a>:</h4>
<p>I think I agree with that</p>



<a name="180145784"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145784" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145784">(Nov 07 2019 at 15:57)</a>:</h4>
<p>(4 min left, so agreed)</p>



<a name="180145799"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145799" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145799">(Nov 07 2019 at 15:57)</a>:</h4>
<p>We'll leave the nominated tag on it</p>



<a name="180145806"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145806" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145806">(Nov 07 2019 at 15:57)</a>:</h4>
<p>I think it's probably worth having some comments asynchronously</p>



<a name="180145831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180145831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180145831">(Nov 07 2019 at 15:57)</a>:</h4>
<p>nom 4/4: "PowerPC C ABI fixes" <a href="https://github.com/rust-lang/rust/issues/64259" target="_blank" title="https://github.com/rust-lang/rust/issues/64259">#64259</a></p>



<a name="180146352"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180146352" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180146352">(Nov 07 2019 at 16:02)</a>:</h4>
<p>(moved conversation to <a href="#narrow/stream/131828-t-compiler/topic/PowerPC.20C.20ABI.20fixes.20PR.20.2364259/near/180145845" title="#narrow/stream/131828-t-compiler/topic/PowerPC.20C.20ABI.20fixes.20PR.20.2364259/near/180145845">other topic</a>)</p>



<a name="180146371"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-11-07%20%2354818/near/180146371" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-11-07.20.2354818.html#180146371">(Nov 07 2019 at 16:02)</a>:</h4>
<p>okay, thanks for coming everyone in <span class="user-group-mention" data-user-group-id="897">@T-compiler/meeting</span>  !!!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>